errose28 commented on code in PR #10902:
URL: https://github.com/apache/ozone/pull/10902#discussion_r3692144451
##########
hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/ozone/admin/upgrade/TestFinalizeSubCommand.java:
##########
@@ -297,10 +297,10 @@ public void testWaitFlagWithVerbosePrintsFullStatus()
throws Exception {
private static QueryUpgradeStatusResponse inProgressStatus(int dnFinalized,
int dnTotal) {
return QueryUpgradeStatusResponse.newBuilder()
- .setOmFinalized(false)
- .setClusterFinalized(false)
+ .setOmFinalizationStatus(HddsProtos.FinalizationStatus.UNFINALIZED)
Review Comment:
This setup was kind of confusing because with the latest changes only the
value of `clusterFinalizationStatus` matters in the test. All other values are
just placeholders to construct a valid object. I'll update this in the next
commit so this and `finalizedStatus` don't take parameters and have javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
