ashishkumar50 commented on PR #10928: URL: https://github.com/apache/ozone/pull/10928#issuecomment-5177916051
> Thanks @ashishkumar50 for reviewing. > > I updated the PR branch with the latest [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) changes, since this PR is currently opened against the [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) feature branch. > > After the update, I still don’t see an existing caller for `recordPendingAllocation(...)` in the allocation path. This PR adds it after the container is added to `containerStateManager`. > > Please let me know if I missed another path that already handles this, thanks. Check space and record allocation is atomic. You can see [here](https://github.com/apache/ozone/blob/40cd903440e7b84017461eccdaf4075f72f58a89/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java#L245). It seems your feature branch is still pointing to old master branch code. You can update your feature branch to latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
