F64116045 commented on PR #10928: URL: https://github.com/apache/ozone/pull/10928#issuecomment-5179741793
> By rebasing the feature branch with master, your PR will not being lot of diff. Rather your PR changes will still be specific to Storage Policy and atomic allocation flow. So steps below: Rebase [HDDS-11233](https://issues.apache.org/jira/browse/HDDS-11233) with master. It will help any future PRs raised against this feature branch will be less deviated from master and easy for feature branch to merge to master later. After that rebase your PR branch with feature branch, diff should be minimal and focused only for storage policy adaption code. Thanks, that makes sense. I agree that rebasing HDDS-11233 with master first would keep this PR and future PRs against the feature branch closer to master. Since I don’t have permission to update the HDDS-11233 branch directly, I would appreciate help with rebasing the feature branch when possible. After HDDS-11233 is rebased with master, I’ll rebase my PR branch on top of it. Thanks @devmadhuu @ashishkumar50 again for clarifying this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
