chungen0126 commented on code in PR #10946:
URL: https://github.com/apache/ozone/pull/10946#discussion_r3747099300
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
Review Comment:
It would be better to change this to `ozone.server.default.storage.tier`.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocol/ScmBlockLocationProtocol.java:
##########
@@ -49,26 +48,6 @@ public interface ScmBlockLocationProtocol extends Closeable {
*/
long versionID = 1L;
- /**
- * Asks SCM where a block should be allocated. SCM responds with the
- * set of datanodes that should be used creating this block.
- * @param size - size of the block.
- * @param numBlocks - number of blocks.
- * @param type - replication type of the blocks.
- * @param factor - replication factor of the blocks.
- * @param excludeList List of datanodes/containers to exclude during block
- * allocation.
- * @return allocated block accessing info (key, pipeline).
- * @throws IOException
- */
- @Deprecated
- default List<AllocatedBlock> allocateBlock(long size, int numBlocks,
- ReplicationType type, ReplicationFactor factor, String owner,
- ExcludeList excludeList) throws IOException, TimeoutException {
- return allocateBlock(size, numBlocks, ReplicationConfig
- .fromProtoTypeAndFactor(type, factor), owner, excludeList);
- }
-
Review Comment:
Since `ScmBlockLocationProtocol` is a public RPC protocol interface,
removing this method changes the interface signatures and may break
binary/backward compatibility for older clients or dependencies that haven't
been recompiled against the new version (causing `NoSuchMethodError` at
runtime).
Is there a reason to remove this deprecated default method in this PR, or
should we retain it for backward compatibility?
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -718,6 +719,10 @@ public final class OzoneConfigKeys {
public static final String OZONE_DEFAULT_STORAGE_TIER_DEFAULT =
StorageTier.DISK.toString();
+ public static final String OZONE_DEFAULT_STORAGE_POLICY_KEY =
"ozone.default.storagepolicy";
Review Comment:
It would be better to change this to `ozone.server.default.storage.policy`.
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -4300,6 +4300,18 @@
</description>
</property>
+ <property>
+ <name>ozone.default.storagepolicy</name>
Review Comment:
It would be better to change this to `ozone.server.default.storage.policy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
