xichen01 commented on code in PR #10946:
URL: https://github.com/apache/ozone/pull/10946#discussion_r3777269270
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocol/ScmBlockLocationProtocol.java:
##########
@@ -49,26 +48,6 @@ public interface ScmBlockLocationProtocol extends Closeable {
*/
long versionID = 1L;
- /**
- * Asks SCM where a block should be allocated. SCM responds with the
- * set of datanodes that should be used creating this block.
- * @param size - size of the block.
- * @param numBlocks - number of blocks.
- * @param type - replication type of the blocks.
- * @param factor - replication factor of the blocks.
- * @param excludeList List of datanodes/containers to exclude during block
- * allocation.
- * @return allocated block accessing info (key, pipeline).
- * @throws IOException
- */
- @Deprecated
- default List<AllocatedBlock> allocateBlock(long size, int numBlocks,
- ReplicationType type, ReplicationFactor factor, String owner,
- ExcludeList excludeList) throws IOException, TimeoutException {
- return allocateBlock(size, numBlocks, ReplicationConfig
- .fromProtoTypeAndFactor(type, factor), owner, excludeList);
- }
-
Review Comment:
This interface was marked as deprecated in 2021, and it is no longer called
anywhere. So we should be able to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
