aryangupta1998 commented on code in PR #11021:
URL: https://github.com/apache/ozone/pull/11021#discussion_r3801822701
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyLifecycleService.java:
##########
@@ -1357,8 +1357,16 @@ private void onSuccess(String bucketName) {
private void handleAndClearFullList(OmBucketInfo bucket,
LimitedExpiredObjectList keysList,
boolean dir, OmLifecycleScanState.Builder scanStateBuilder, boolean
scanFinished) {
if (moveToTrashEnabled.get() && bucket.getBucketLayout() != OBJECT_STORE
&& getEffectiveOzoneTrash() != null) {
- moveToTrash(bucket, keysList, dir);
- sendSaveScanStateRequest(scanStateBuilder, scanFinished);
+ int failedMoves = moveToTrash(bucket, keysList, dir);
+ if (failedMoves == 0) {
Review Comment:
Good catch. Not advancing scan state when failedMoves > 0 is intentional for
real rename failures, so we don’t silently skip entries.
I updated moveToTrash to treat idempotent missing-source cases
(KEY_NOT_FOUND, FILE_NOT_FOUND, DIRECTORY_NOT_FOUND) as non-failures, so they
no longer force repeated rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
