ChenSammi commented on code in PR #11021:
URL: https://github.com/apache/ozone/pull/11021#discussion_r3813536799
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyLifecycleService.java:
##########
@@ -1599,8 +1609,16 @@ public OzoneManagerProtocolProtos.OMResponse run()
throws Exception {
});
if (omResponse != null) {
if (!omResponse.getSuccess()) {
+ OzoneManagerProtocolProtos.Status status =
omResponse.getStatus();
+ if (isMissingSourceStatus(status)) {
+ LOG.info("Skip retry for missing source key: {} while moving
to trash key: {}, status: {}",
+ keyName, targetKeyName, status);
+ continue;
+ }
// log the failure and continue the iterating
- LOG.error("RenameKey request failed with source key: {}, dest
key: {}", keyName, targetKeyName);
+ LOG.error("RenameKey request failed with source key: {}, dest
key: {}, status: {}",
Review Comment:
This status logging is good to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
