swamirishi commented on code in PR #11068:
URL: https://github.com/apache/ozone/pull/11068#discussion_r3819028356
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/TypedTable.java:
##########
@@ -228,6 +229,24 @@ public VALUE getSkipCache(KEY key) throws
RocksDatabaseException, CodecException
return getFromTable(key);
}
+ @Override
+ public List<VALUE> multiGetSkipCache(List<KEY> keys)
Review Comment:
Please implement CodeBuffer based multiGets as well otherwise the GC
pressure on memory would be bad
https://github.com/facebook/rocksdb/blob/805ac7c887bbebd7e6124bbc7e8d0803aeed8f07/java/src/main/java/org/rocksdb/RocksDB.java#L2435-L2460
You would need to implement a similar function like
https://github.com/apache/ozone/blob/9fa7fffb4c6245caaad305655a73501bfb5f6bb6/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/TypedTable.java#L318-L355
to ensure the value which didn't fit in the first multiget should be called
again with a resized CodecBuffer size.
So the first call should do a multiGet with all CodecBuffer keys and based
on the status list returned we need to call multiget again for the ones which
didn't fit in the initial fit and collate the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
