SaketaChalamchala commented on code in PR #11068:
URL: https://github.com/apache/ozone/pull/11068#discussion_r3898359142
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBTable.java:
##########
@@ -122,10 +124,32 @@ public byte[] get(byte[] key) throws
RocksDatabaseException {
return db.get(family, key);
}
+ @Override
+ public List<byte[]> multiGetSkipCache(List<byte[]> keys) throws
RocksDatabaseException {
+ if (keys == null || keys.isEmpty()) {
+ return Collections.emptyList();
+ }
+ for (byte[] ignored : keys) {
+ rdbMetrics.incNumDBKeyGets();
+ }
+ return db.multiGet(family, keys);
+ }
+
Integer get(ByteBuffer key, ByteBuffer outValue) throws
RocksDatabaseException {
return db.get(family, key, outValue);
}
+ List<ByteBufferGetStatus> multiGetSkipCache(List<ByteBuffer> keys,
List<ByteBuffer> values)
+ throws RocksDatabaseException {
+ if (keys == null || keys.isEmpty()) {
+ return Collections.emptyList();
+ }
+ for (ByteBuffer ignored : keys) {
+ rdbMetrics.incNumDBKeyGets();
Review Comment:
Need to add the `incNumDBKeyGets(n)` getter to the `RDBMetrics`. Maybe we
can address this in a follow up PR for metric improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
