jojochuang commented on PR #9640: URL: https://github.com/apache/ozone/pull/9640#issuecomment-5375673369
This looks ready to merge from a prerequisites standpoint — the blockers called out earlier have landed on master: - #9693 (HDDS-13670) — `javac.version` → `maven.compiler.release` - #9736 (HDDS-14595) — split `ozone-cli-debug` / `ozone-cli-repair` from `ozone-tools` - #9874 (HDDS-14771) — split server load testers to `ozone-vapor`; freon stays client-side I'd suggest merging after rebase + green CI, and tracking the rest as follow-up Jiras/PRs rather than holding this PR open: 1. **Rebase onto master + CI** — add Java 17 overrides for modules created after this branch was cut: `ozone-cli-debug`, `ozone-cli-repair`, `ozone-vapor`, `ozone-cli-admin`. (`ozone-freon` → Java 8 is already covered here.) 2. **`hdds-framework` vs admin Java 17** — framework is client Java 8 because `ozone-cli-admin` depends on it, but admin/debug/repair need Java 17 at runtime. Follow-up to decide whether the current layout is acceptable or dependencies should be adjusted. 3. **Documentation & packaging** — only `CONTRIBUTING.md` is updated in this PR. Follow-up in this repo for `AGENTS.md`, `.github/ci.md`, release notes, RPM `java-headless >= 1.8.0` in `dist/pom.xml`, Docker/compose images, and the `ozone` launcher iceberg guard. 4. **Ozone website & user docs ([ozone-site](https://github.com/apache/ozone-site))** — follow-up PR(s) there to document the new build/runtime requirements (JDK 17 for server components, Java 8 for client), including installation and deployment guides. 5. **SpotBugs / HDDS-10150** — disabling findbugs here is a reasonable interim step; follow-up PR to upgrade SpotBugs 4 and address the ~2K warnings. 6. **`populate-cache.yml`** — follow-up to drop the separate Java 8 cache-warm pass once server default is 17. 7. **Post-merge verification** — confirm Java 8 client compatibility tests still pass with freon on Java 8 bytecode after rebase (structural fix is in via #9874). 8. **Iceberg pom cleanup** — minor follow-up to update the Java 11 override comment once server default becomes 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
