adoroszlai commented on PR #9640: URL: https://github.com/apache/ozone/pull/9640#issuecomment-5407970047
> This looks ready to merge from a prerequisites standpoint > > I'd suggest merging after rebase + green CI, and tracking the rest as follow-up Jiras/PRs rather than holding this PR open: This was held back to make the Java version change in new major version 3.0. Not sure if we are OK to do it in minor version 2.3. > 1. **Rebase onto master + CI** — add Java 17 overrides for modules created after this branch was cut: `ozone-cli-debug`, `ozone-cli-repair`, `ozone-vapor`, `ozone-cli-admin`. (`ozone-freon` → Java 8 is already covered here.) Not adding override for java 17, as discussed in https://github.com/apache/ozone/pull/9640#issuecomment-3825106011 (but later switched from "default + server" to "default + client"). > 2. **`hdds-framework` vs admin Java 17** — framework is client Java 8 because `ozone-cli-admin` depends on it, but admin/debug/repair need Java 17 at runtime. Follow-up to decide whether the current layout is acceptable or dependencies should be adjusted. `ozone-cli-admin` only needs Java 8, inherits version from `hdds-hadoop-dependency-client`. > 6. **`populate-cache.yml`** — follow-up to drop the separate Java 8 cache-warm pass once server default is 17. Fixed now, since it would be breaking `populate-cache` workflow. > 7. **Post-merge verification** — confirm Java 8 client compatibility tests still pass with freon on Java 8 bytecode after rebase (structural fix is in via [HDDS-14771. Split server-side load testers from freon #9874](https://github.com/apache/ozone/pull/9874)). This does not need new task, CI for this PR covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
