rich7420 commented on code in PR #10781:
URL: https://github.com/apache/ozone/pull/10781#discussion_r3838825982
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java:
##########
@@ -376,4 +402,27 @@ public static OMRequest
disallowSetBucketPropertyWithECReplicationConfig(
}
return req;
}
+
+ @RequestFeatureValidator(
+ conditions = ValidationCondition.CLUSTER_NEEDS_FINALIZATION,
+ processingPhase = RequestProcessingPhase.PRE_PROCESS,
+ requestType = Type.SetBucketProperty
+ )
+ public static OMRequest disallowSetBucketPropertyWithVersioningStatus(
Review Comment:
This gate covers `SetBucketProperty`, but `CreateBucket` carries the same
`BucketInfo.versioningStatus` and persists it (`OmBucketInfo.getFromProtobuf`)
with no matching `OBJECT_VERSIONING` validator — so a pre-finalized cluster
would accept a `CreateBucket` that sets it, bypassing this contract (and the
create path runs no `canTransitionTo`). Not triggerable yet since no client
sends the field. Worth mirroring this validator on `Type.CreateBucket`, or a
TODO + follow-up Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
