symious commented on code in PR #10781:
URL: https://github.com/apache/ozone/pull/10781#discussion_r3840446806
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java:
##########
@@ -376,4 +402,27 @@ public static OMRequest
disallowSetBucketPropertyWithECReplicationConfig(
}
return req;
}
+
+ @RequestFeatureValidator(
+ conditions = ValidationCondition.CLUSTER_NEEDS_FINALIZATION,
+ processingPhase = RequestProcessingPhase.PRE_PROCESS,
+ requestType = Type.SetBucketProperty
+ )
+ public static OMRequest disallowSetBucketPropertyWithVersioningStatus(
Review Comment:
Good catch. Following S3 here: CreateBucket has no versioning parameter,
versioning is only set on an existing bucket via PutBucketVersioning. So
instead of the layout gate, T1.2 now rejects any CreateBucket carrying
versioningStatus outright with INVALID_REQUEST. That covers post-finalization
too, so I dropped the mirrored validator from T1.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
