peterxcli commented on code in PR #11102:
URL: https://github.com/apache/ozone/pull/11102#discussion_r3866009901
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -131,6 +131,15 @@ public final class OzoneConfigKeys {
public static final boolean OZONE_FS_HSYNC_ENABLED_DEFAULT
= false;
+ /**
+ * When true, synchronize seek-read-restore in OzoneFSInputStream positioned
+ * reads for thread-safe pread on a shared input stream.
+ */
+ public static final String OZONE_FS_SYNCHRONIZE_POSITIONED_READS_ENABLED =
+ "ozone.fs.synchronize.positioned.reads.enabled";
+ public static final boolean
OZONE_FS_SYNCHRONIZE_POSITIONED_READS_ENABLED_DEFAULT =
+ false;
Review Comment:
should we remove this config and make the `FSInputStream` to probe if its
underlying input stream support stateless read,
- if yes, use stateless `pread`.
- if no, always synchronize seek/read/restore.
otherwise this config would be the surprise to users who expect the ozone's
`ByteBufferPositionedReadable` is thread-safe out-of-the-box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
