taklwu commented on code in PR #11102:
URL: https://github.com/apache/ozone/pull/11102#discussion_r3867018657
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -131,6 +131,15 @@ public final class OzoneConfigKeys {
public static final boolean OZONE_FS_HSYNC_ENABLED_DEFAULT
= false;
+ /**
+ * When true, synchronize seek-read-restore in OzoneFSInputStream positioned
+ * reads for thread-safe pread on a shared input stream.
+ */
+ public static final String OZONE_FS_SYNCHRONIZE_POSITIONED_READS_ENABLED =
+ "ozone.fs.synchronize.positioned.reads.enabled";
+ public static final boolean
OZONE_FS_SYNCHRONIZE_POSITIONED_READS_ENABLED_DEFAULT =
+ false;
Review Comment:
I removed it
FYI original before the stateless read was implemented after @yandrey321
comments, I don't want to introduce surprise with `synchronize` seek. now
after few round of improvement, I think it's good to always fall back to
synchronize seek for all non-ExtendedInputStream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
