F64116045 commented on code in PR #11158:
URL: https://github.com/apache/ozone/pull/11158#discussion_r3890999579
##########
hadoop-ozone/mini-cluster/src/main/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java:
##########
@@ -622,11 +623,11 @@ protected void initializeConfiguration() throws
IOException {
}
private void configureHostAndRackTopology() throws IOException {
- FixedHostMapping.clear();
if (racks == null && hosts == null) {
return;
}
+ StaticMapping.resetMap();
Review Comment:
> Thanks for checking this, I think TestStorageContainerManager
configureTopology can be moved to MiniOzoneCluster setRacks and setHosts? How
about we address it here?
Thanks, updated `TestStorageContainerManager` to use `setHosts()` and
`setRacks()`.
Also there are still two similar,
[TestFailureHandlingByClient](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestFailureHandlingByClient.java#L140-L146)
and
[TestFailureHandlingByClientFlushDelay](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestFailureHandlingByClientFlushDelay.java#L113-L128),
that configure the client host directly.
Since `setHosts()` and `setRacks()` define one host & rack pair per datanode
and do not provide a way to configure the client host, those tests still need
to configure the client mapping directly. Therefore, I kept the startup reset
after the null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
