F64116045 commented on code in PR #11158:
URL: https://github.com/apache/ozone/pull/11158#discussion_r3891053564
##########
hadoop-ozone/mini-cluster/src/main/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java:
##########
@@ -536,7 +547,7 @@ public MiniOzoneCluster build() throws IOException {
// Recreate the Ratis pipeline to prevent imbalanced node placement
across racks
// caused by asynchronous DN registration.
- if (racks != null && startDataNodes) {
+ if (racks != null && startDataNodes && numOfDatanodes >=
HddsProtos.ReplicationFactor.THREE.getNumber()) {
Review Comment:
Just to explain this additional change:
`TestStorageContainerManager` now calls `setRacks()` with only one datanode,
but `resetPipelinesForRackAwareness()` requires at least three.
Without this check, the cluster fails to start. This is safe because the
method only recreates a pipeline that requires three datanodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]