spacemonkd commented on PR #10900: URL: https://github.com/apache/ozone/pull/10900#issuecomment-5480915997
Thanks for bearing with me @chihsuan. The extensive review is really helpful. I have addressed the issues, hoping I have not missed anything this time. Added some more unit tests using Claude and also returning undefined for empty/non-JSON 2xx bodies. Also `buildJvmHighlights` guards `SystemProperties ?? []` which could have caused an error. Could you take another look? Please feel free to let me know if you think we can still improve anything, we can create follow up JIRAs to improve since this is going into the feature branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
