spacemonkd commented on PR #10900:
URL: https://github.com/apache/ozone/pull/10900#issuecomment-5582288842
Thanks @chihsuan for your effort in testing and reviewing this patch.
I have addressed the review comments you gave.
Also I have done the following:
- `ThemeProvider` now wraps children in `<App component={false}>`.
`SyncChip` and `JvmContent` use `App.useApp()`'s message instead of the static
import so toasts inherit the theme.
- Removed moment from the package.json
Having a watch script / alias to shared components was not handled here. We
can file a JIRA and do that separately.
Would you like to do that and pick it up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
