ivandika3 commented on code in PR #11056:
URL: https://github.com/apache/ozone/pull/11056#discussion_r3920920527
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdiff/TestRocksDiffUtils.java:
##########
@@ -106,10 +105,7 @@ validSstFile, new SstFileInfo(validSstFile,
validSSTFileStartRange, validSSTFile
RocksDiffUtils.filterRelevantSstFiles(inputSstFiles,
tablesToLookup,
new TablePrefixInfo(
- new HashMap<String, String>() {{
- put(invalidColumnFamilyName,
getLexicographicallyHigherString(invalidSSTFileEndRange));
- put(validSSTColumnFamilyName, expectedPrefix);
- }}));
+ ImmutableMap.of(validSSTColumnFamilyName, expectedPrefix)));
Review Comment:
Reworked the parameter rows to use distinct valid and invalid column-family
names, then used a mutable `HashMap` to retain both prefixes. The invalid
prefix is lexicographically beyond its SST end range, so the test still
exercises exclusion while preserving the original intent.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java:
##########
@@ -518,6 +518,7 @@ public static TraceCloseable createActivatedSpan(String
spanName) {
return createActivatedSpan(spanName, SpanKind.INTERNAL);
}
+ @SuppressWarnings("MustBeClosedChecker")
Review Comment:
Added rationale comments next to both `MustBeClosedChecker` suppressions:
the returned `TraceCloseable` closes the `Scope` and ends the `Span`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
