sravani-revuri commented on code in PR #11183:
URL: https://github.com/apache/ozone/pull/11183#discussion_r3921769350
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -579,7 +578,7 @@ public void testHSyncOpenKeyDeletionWhileDeleteDirectory()
throws Exception {
os.write(1);
os.hsync();
// There should be 1 key in openFileTable
- assertThat(1 == getOpenKeyInfo(BUCKET_LAYOUT).size());
+ assertEquals(1, getOpenKeyInfo(BUCKET_LAYOUT).size());
Review Comment:
Minor question:
As i see in `testHSyncOpenKeyCommitAfterExpiry` now the keys are checked to
avoid failure from other tests having entries in the respective tables. Curious
why this test also isn't doing the same or is it safe to assume the open table
is empty from earlier tests?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
Review Comment:
nit: Unrelated to change, but should this be renamed to `fileTable` since it
reads Keytable not open one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
