shuan1026 commented on code in PR #11183:
URL: https://github.com/apache/ozone/pull/11183#discussion_r3924075291
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -579,7 +578,7 @@ public void testHSyncOpenKeyDeletionWhileDeleteDirectory()
throws Exception {
os.write(1);
os.hsync();
// There should be 1 key in openFileTable
- assertThat(1 == getOpenKeyInfo(BUCKET_LAYOUT).size());
+ assertEquals(1, getOpenKeyInfo(BUCKET_LAYOUT).size());
Review Comment:
> Minor question: As i see in `testHSyncOpenKeyCommitAfterExpiry` now the
keys are checked to avoid failure from other tests having entries in the
respective tables. Curious why this test also isn't doing the same or is it
safe to assume the open table is empty from earlier tests?
Thanks for the review @sravani-revuri! Yes, it isn't safe to assume that.
Scoped this test the same way: the size check, the DELETED_HSYNC_KEY wait
and the final wait now all filter to this test's key. Also filtered the one
remaining whole-table wait in testHSyncOpenKeyCommitAfterExpiry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
