hani-fouladgar commented on code in PR #11218:
URL: https://github.com/apache/ozone/pull/11218#discussion_r4039759166
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -5764,6 +5769,48 @@ public ListSnapshotDiffJobResponse listSnapshotDiffJobs(
}
}
+ /**
+ * Reload the block and container SCM failover proxies after the SCM node
list
+ * ({@code ozone.scm.nodes.<serviceId>}) is reconfigured, so the OM can
reach a
+ * newly added SCM without a restart. The per-node address keys
+ * ({@code ozone.scm.address.<serviceId>.<nodeId>}) must already be present
for
+ * the involved nodes.
+ *
+ * Scope: only the block and container proxies are reloaded here. Changing an
+ * address key alone does not trigger a reload; touch the node list to apply
Review Comment:
Real bug — fixed. Prefix-registered address keys have no per-key reload
function, so an address-only change was never applied. reconfScmNodes now
defers on ConfigurationException (keeps the value instead of rolling back), and
a new reconfiguration-complete callback reloadScmProxiesOnReconfig reloads once
the whole batch is applied. So an address-only change takes effect, and adding
a node works in a single reconfig start regardless of key order. Covered by the
new testReconfigureScmAddressReloadsProxies integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
