hani-fouladgar commented on code in PR #11218:
URL: https://github.com/apache/ozone/pull/11218#discussion_r4048388256
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -5764,6 +5769,48 @@ public ListSnapshotDiffJobResponse listSnapshotDiffJobs(
}
}
+ /**
+ * Reload the block and container SCM failover proxies after the SCM node
list
+ * ({@code ozone.scm.nodes.<serviceId>}) is reconfigured, so the OM can
reach a
+ * newly added SCM without a restart. The per-node address keys
+ * ({@code ozone.scm.address.<serviceId>.<nodeId>}) must already be present
for
+ * the involved nodes.
+ *
+ * Scope: only the block and container proxies are reloaded here. Changing an
+ * address key alone does not trigger a reload; touch the node list to apply
Review Comment:
You were right: the defer left a node without an address in the live conf
while reporting SUCCESS, breaking getServiceList(). reconfScmNodes now captures
the previous node-list value, and on a reload ConfigurationException it
restores the previous value and rethrows. ReconfigurationHandler wraps that
into a ReconfigurationException, so the reconfig is reported FAILED and is
retriable, and the live conf never keeps an SCM without a resolvable address.
This mirrors the datanode's "don't record what didn't take effect" semantics
(the datanode returns only its effective node set; the OM can't skip per-node
because changeConfig() rebuilds the whole proxy list atomically, so
roll-back-and-fail is the equivalent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
