symious commented on pull request #2448: URL: https://github.com/apache/ozone/pull/2448#issuecomment-885448139
@bharatviswa504 Thanks for the review. I have checked the PR of #2433 , but I'm not sure we need to use another variable to control if we need to delete the old locations only for buckets with versioning disabled. Personally, I'm very glad to see the feature of versioning in Ozone, and I think if it's released, it should be very welcomed by users. IMHO, if the feature was released, everyone likes the feature, most of the users will have this feature enabled, and the issue will still exist. As we discussed in https://github.com/apache/ozone/pull/2261#issuecomment-843308499, if there are 1000 versions, it's ok to have 1000 storage and process units for all versions, the issue we have now is its redundancy causing 500500 storage and process units. I think 1000 is acceptable with the advantage that we don't even have to change the original design too much but restored all the original locations. If there is some automatic program rewriting the same forever, causing a very large version location, I think what we need is a version limit mechanism that can control the malicious case here. I think this would be a better way to align with the future release of versioning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
