symious commented on pull request #2448: URL: https://github.com/apache/ozone/pull/2448#issuecomment-886405596
@kuenishi Thanks for the review. I think option 2 is preferable too. Since the current overhead is caused by the redundancy in multi-version storing, if we have this patch or the initial patch in #2433, the issue would be solved quite a lot. The overhead we have now to rewrite a file 1000 times would cost users to rewrite over 500000 times with the patch. The issue that the version can really become very large since it's unlimited will exists, and the structure of RocksDB storing keys might need some changes, but IMHO it can be considered when developing the feature of versioning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
