JacksonYao287 commented on a change in pull request #2438:
URL: https://github.com/apache/ozone/pull/2438#discussion_r676230976
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImplV2.java
##########
@@ -203,9 +208,11 @@ public void commitTransactions(
for (DeleteBlockTransactionResult transactionResult :
transactionResults) {
if (isTransactionFailed(transactionResult)) {
+ metrics.incrementDeleteTxFailure();
continue;
}
try {
+ metrics.incrementDeleteTxSuccess();
Review comment:
thanks for the work! i think we should put this at line 231, because
there may comes a retried delete command response, and for the retried response
, maybe we should not increase the corresponding metric, or maybe we can add a
new metric specially for retried command!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
