ChenSammi commented on a change in pull request #2438:
URL: https://github.com/apache/ozone/pull/2438#discussion_r676316785
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImplV2.java
##########
@@ -203,9 +208,11 @@ public void commitTransactions(
for (DeleteBlockTransactionResult transactionResult :
transactionResults) {
if (isTransactionFailed(transactionResult)) {
+ metrics.incrementDeleteTxFailure();
continue;
}
try {
+ metrics.incrementDeleteTxSuccess();
Review comment:
@JacksonYao287 , thanks for the review. One thing is there is no resent
command, but resent transactions. Transactions holds in every command can be
different. When transaction is resent, it's added into
numBlockDeletionTransactionSent. So, the reply of the resent transaction should
be accountable.
The number of resent transaction can be get throught
(numBlockDeletionTransactionSent - numBlockDeletionTransactionCreated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
