chihsuan commented on PR #10671:
URL: https://github.com/apache/ozone/pull/10671#issuecomment-5826047882
Thanks @adoroszlai, this is a nice improvement!
With Claude’s help, I simulated the new check against 1,000 master commits.
I found a few cases where selecting tests by changed class name may miss
related tests:
- `TestOmSnapshotFileSystem` is an abstract test class; its nested test
suites are discovered through `TestOzoneSnapshotsNonHA`.
- `TestOmKeyInfo` and `TestOMKeyCreateResponse` are test classes with
subclasses whose names differ.
- `TestContainerCorruptions` and `TestRawSstFileRecords` are helpers,
while `TestOMLifecycleConfigurationRequest` is a base class.
Since `TestRawSstFileRecords` came in after the renames, I was wondering if
it's worth guarding against new cases sneaking in. A couple of ideas, perhaps
for later:
- Check whether a changed `Test*` class is a test class or a helper/base
class.
- Include subclasses of changed test classes when selecting tests.
I’m not sure either check is worth the added complexity, but I wanted to
flag the cases I found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
