adoroszlai commented on PR #10671: URL: https://github.com/apache/ozone/pull/10671#issuecomment-5829365218
Thanks @chihsuan for checking. > * `TestOmSnapshotFileSystem` is an abstract test class; its nested test suites are discovered through `TestOzoneSnapshotsNonHA`. There are many cases like this, where several test classes were grouped to run on the same mini cluster. Most of the grouping classes are in the `org.apache.ozone.test` package, which is always added to `test-classes`: https://github.com/apache/ozone/blob/d16ea56667fae637ef29d5795f26beab5c4f5beb/dev-support/ci/selective_ci_checks.sh#L278-L279 Looks like `TestOzoneSnapshotsNonHA` should be moved to that package. > * `TestOmKeyInfo` and `TestOMKeyCreateResponse` are test classes with subclasses whose names differ. - `TestOMFileCreateResponseWithFSO` duplicates `TestOMKeyCreateResponseWithFSO`, can be deleted. - `TestOmKeyInfo` vs. `TestOmKeyInfoWithHadoop2`: I don't really know how to > * `TestContainerCorruptions` and `TestRawSstFileRecords` are helpers, while `TestOMLifecycleConfigurationRequest` is a base class. Looks like more renaming is needed. > wondering if it's worth guarding against new cases sneaking in. A couple of ideas, perhaps for later: > ... > - Check whether a changed `Test*` class is a test class or a helper/base class. If we can come up with criteria to distinguish between the two (in CI). > - Include subclasses of changed test classes when selecting tests. That would be a nice follow-up, may be able to remove the `WithFSO` hack. > I’m not sure either check is worth the added complexity, but I wanted to flag the cases I found. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
