umamaheswararao commented on a change in pull request #2430:
URL: https://github.com/apache/ozone/pull/2430#discussion_r676356496
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfig.java
##########
@@ -63,7 +64,14 @@ static ReplicationConfig fromTypeAndFactor(
}
static ReplicationConfig getDefault(ConfigurationSource config) {
- return new RatisReplicationConfig(HddsProtos.ReplicationFactor.THREE);
+ String replication = config.get(OzoneConfigKeys.OZONE_REPLICATION);
+ String replType = config.get(OzoneConfigKeys.OZONE_REPLICATION_TYPE);
+ ReplicationConfig replicationConfig = null;
+ if (replication != null && replType != null) {
+ replicationConfig = ReplicationConfig
+ .fromTypeAndString(ReplicationType.valueOf(replType), replication);
+ }
Review comment:
Not sure we get the null there. ozone-defaults xml will always contains
the default values right?
Why I added null checks were to handle a test issues(TestOzoneClient) which
uses InMemoryConfiguration
But in practice, we should not get null values there. do you think we have
some possibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
