umamaheswararao commented on a change in pull request #2430:
URL: https://github.com/apache/ozone/pull/2430#discussion_r681423518
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfig.java
##########
@@ -63,7 +64,14 @@ static ReplicationConfig fromTypeAndFactor(
}
static ReplicationConfig getDefault(ConfigurationSource config) {
- return new RatisReplicationConfig(HddsProtos.ReplicationFactor.THREE);
+ String replication = config.get(OzoneConfigKeys.OZONE_REPLICATION);
+ String replType = config.get(OzoneConfigKeys.OZONE_REPLICATION_TYPE);
+ ReplicationConfig replicationConfig = null;
+ if (replication != null && replType != null) {
+ replicationConfig = ReplicationConfig
+ .fromTypeAndString(ReplicationType.valueOf(replType), replication);
+ }
Review comment:
Currently I have not removed replication and factor parameters from
ozone-default.xml, so we not get null. As part EC branch, I am removing them
from ozone-default, so we will get null there and I will remove this null check
there. Once I remove them, it can become null and have to remove it. However if
you feel we should remove it now, I can just remove replicationConfig from that
above null check. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
