Copilot commented on code in PR #11439:
URL: https://github.com/apache/ozone/pull/11439#discussion_r4210352542
##########
THREAT_MODEL.md:
##########
@@ -178,9 +178,10 @@ stock install and must be explicitly enabled:
gRPC traffic when enabled.
- **TDE/KMS** is optional and protects data at rest only for encrypted buckets;
it requires a configured KMS, for example via
`hadoop.security.key.provider.path`.
+- **HTTP authentication (SPNEGO)** is off by default
(`ozone.security.http.kerberos.enabled=false`, and each web server's own type,
for example `ozone.om.http.auth.type=simple`). Without it the web endpoints are
not authenticated, and the admin check of the OM and SCM DB checkpoint
endpoints, which serve the metadata DB, is not applied. *(documented —
`ozone-default.xml`.)*
Review Comment:
This statement does not match the current authorization paths. When
authorization is enabled, OM decides whether to apply the administrator
allowlist solely from `ozone.om.http.auth.type`, so `kerberos` selects the
filter even when global HTTP Kerberos is disabled; SCM passes `false`
unconditionally and never selects it. Describe the two services separately
instead of asserting that both checks track actual SPNEGO authentication.
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3504,6 +3504,8 @@
<tag>OM, SECURITY, KERBEROS</tag>
<description> simple or kerberos. If kerberos is set, SPNEGO
will be used for http authentication.
+ kerberos takes effect only when ozone.security.http.kerberos.enabled is
true.
+ With simple, requests are not authenticated, so the admin check of the
/dbCheckpoint endpoint is not applied.
Review Comment:
The PR explicitly covers both OM checkpoint APIs, and `/v2/dbCheckpoint`
initializes the same authorization logic as `/dbCheckpoint`. Include both paths
so operators do not assume this warning applies only to the legacy endpoint.
This issue also appears on line 3518 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
