smengcl commented on code in PR #11439:
URL: https://github.com/apache/ozone/pull/11439#discussion_r4210484152


##########
THREAT_MODEL.md:
##########
@@ -178,9 +178,10 @@ stock install and must be explicitly enabled:
   gRPC traffic when enabled.
 - **TDE/KMS** is optional and protects data at rest only for encrypted buckets;
   it requires a configured KMS, for example via 
`hadoop.security.key.provider.path`.
+- **HTTP authentication (SPNEGO)** is off by default 
(`ozone.security.http.kerberos.enabled=false`, and each web server's own type, 
for example `ozone.om.http.auth.type=simple`). Without it the web endpoints are 
not authenticated, and the admin check of the OM and SCM DB checkpoint 
endpoints, which serve the metadata DB, is not applied. *(documented — 
`ozone-default.xml`.)*

Review Comment:
   Reworded in bc6ae866853: the bullet now states what the defaults give (the 
endpoints are served without an admin check) and no longer ties the check to 
SPNEGO being in effect. Kept it as one bullet because section 5a lists default 
states.
   
   _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_



##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3504,6 +3504,8 @@
     <tag>OM, SECURITY, KERBEROS</tag>
     <description> simple or kerberos. If kerberos is set, SPNEGO
       will be used for http authentication.
+      kerberos takes effect only when ozone.security.http.kerberos.enabled is 
true.
+      With simple, requests are not authenticated, so the admin check of the 
/dbCheckpoint endpoint is not applied.

Review Comment:
   Added `/v2/dbCheckpoint` to the `ozone.om.http.auth.type` description in 
bc6ae866853. The `hdds.scm.http.auth.type` description is unchanged because SCM 
serves only `/dbCheckpoint`.
   
   _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to