jojochuang commented on PR #11455:
URL: https://github.com/apache/ozone/pull/11455#issuecomment-6220240446
Closing as superseded by master commit
53dadf9cf5b0b6782a3f9875e1e69d90524b8783 ("Improve handling of internal request
types in OMExecutionFlow").
External `CompleteFinalizeUpgrade` is already rejected in `OMExecutionFlow`
via `INTERNAL_CMD_TYPES` with `PERMISSION_DENIED` before Ratis. Coverage:
`TestOzoneManagerRatisRequest#testInternalRequestRejectedFromClient` (parameter
includes `CompleteFinalizeUpgrade`).
This PR's `preExecute()` + `INVALID_REQUEST` path is redundant with that
guard and caused CI failures (expected `INVALID_REQUEST` vs actual
`PERMISSION_DENIED`). Internal completion still uses Ratis directly from
`OMUpgradeFinalizeService` without `preExecute`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
