peterxcli commented on code in PR #11551:
URL: https://github.com/apache/ozone/pull/11551#discussion_r4332453578
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java:
##########
@@ -105,8 +107,19 @@ public StreamBlockInputStream(
XceiverClientFactory xceiverClientFactory,
Function<BlockID, BlockLocationInfo> refreshFunction,
OzoneClientConfig config) throws IOException {
- this.blockID = blockID;
- this.blockLength = length;
+ this(new
BlockLocationInfo.Builder().setBlockID(blockID).setLength(length).build(),
+ pipeline, token, xceiverClientFactory, refreshFunction, config);
+ }
+
+ public StreamBlockInputStream(
+ BlockLocationInfo blockInfo, Pipeline pipeline,
+ Token<OzoneBlockTokenIdentifier> token,
+ XceiverClientFactory xceiverClientFactory,
+ Function<BlockID, BlockLocationInfo> refreshFunction,
+ OzoneClientConfig config) throws IOException {
Review Comment:
let's remove old constructor and stick with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
