chungen0126 commented on PR #11551: URL: https://github.com/apache/ozone/pull/11551#issuecomment-6307693792
> this might add many round trips when streaming read, we might want to add `blockLength` into `ReadBlockResponseProto`, and datanode always keep it up-to-date. Thanks @peterxcli for reviewing this. This adds at most one GetBlock per stream, and only for the last under-construction block. Returning the length in ReadBlockResponseProto requires protocol changes and client EOF check adjustments. Even then, it only helps sequential reads—seeking directly beyond OM's stale length still inevitably requires an RPC. Adding this much complexity just to avoid a single RPC isn't worth it. Let's this in a follow-up JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
