Copilot commented on code in PR #11823:
URL: https://github.com/apache/ozone/pull/11823#discussion_r4400583428
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/OmTestManagers.java:
##########
@@ -105,6 +105,7 @@ public OmTestManagers(OzoneConfiguration conf,
new ScmBlockLocationTestingClient(null, null, 0);
conf.set(ScmConfigKeys.OZONE_SCM_CLIENT_ADDRESS_KEY, "127.0.0.1:0");
+ conf.setIfUnset(OMConfigKeys.OZONE_OM_S3_GPRC_SERVER_ENABLED, "false");
Review Comment:
The config key constant name uses `GPRC` (likely a typo for `GRPC`). If this
is not the exact config key consumed by `GrpcOzoneManagerServer`, the server
won’t actually be disabled and the test speedup won’t apply. Please verify the
constant and underlying property name are correct (and rename to
`...S3_GRPC...` if this was introduced/edited incorrectly).
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/OmTestManagers.java:
##########
@@ -105,6 +105,7 @@ public OmTestManagers(OzoneConfiguration conf,
new ScmBlockLocationTestingClient(null, null, 0);
conf.set(ScmConfigKeys.OZONE_SCM_CLIENT_ADDRESS_KEY, "127.0.0.1:0");
+ conf.setIfUnset(OMConfigKeys.OZONE_OM_S3_GPRC_SERVER_ENABLED, "false");
Review Comment:
Prefer avoiding the raw string literal \"false\" when setting boolean
configs (e.g., using `Boolean.toString(false)` or a boolean-specific setter if
available) to reduce typo risk and keep boolean config usage consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
