errose28 opened a new pull request, #11834: URL: https://github.com/apache/ozone/pull/11834
**DRAFT until 2.3.0 is released with initial ZDU support and https://github.com/apache/ozone-site/pull/560 is merged** ## What changes were proposed in this pull request? Add a regex based script that inspects git diffs and warns if they contain potentially incompatible changes. When the script is triggered on a PR, it will add a comment if any patterns match potentially incompatible changes. This just a "heads up" and will produce false positives which can be ignored. It has no bearing on the merge-ability or CI status of the PR. The script is triggered by a github action modeled after the existing `label-pr` workflow, where PRs are periodically scanned and updated in batches. The script has handling to avoid duplicate comments when either the PR content or the warnings do not change between runs. The workflow can also be triggered manually, with an option to run it against all PRs in the queue, or just those updated within the last 2 hours. This workflow and the existing `label-pr` workflow are now triggered in the same spot at the same interval. Currently it seems simpler to have one dispatcher for all periodic scan tasks like this, although we could optionally create one dispatcher per workflow. ## Jira Link HDDS-17252 ## How was this patch tested? - Detection shell script: - `bats` test added to test the shell script's output against real commits in the history - Manual runs of the script against diffs locally - Github actions automation: A [modified version](https://github.com/errose28/ozone/tree/worktree/incompat-static-analysis-test) of this workflow was [run](https://github.com/errose28/ozone/actions/runs/40773247655/job/123115734034) against two fake PRs in my fork - [This one](https://github.com/errose28/ozone/pull/10) did not get a warning - [This one](https://github.com/errose28/ozone/pull/9) did get a warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
