adoroszlai commented on PR #11834: URL: https://github.com/apache/ozone/pull/11834#issuecomment-6492094716
Thanks @errose28 for the patch. I'll review in detail, some questions/thoughts up front: - This approach could be used to set PR CI status from contributor fork (to replace `pull_request` triggered runs), which does not need to wait for the ZDU specific conditions (2.3.0 release, docs update). Adding a marker to distinguish github-bot comments for various purposes is a great idea. - As the number of items to check periodically for PRs may increase in the future, the current approach iterating PRs in separate jobs may not scale. Should PRs be iterated once to execute various scripts on each (i.e. should the dispatcher be at the shell-script level instead of in the workflow)? - We could store state between runs using Apache Infra's [Stash action](https://github.com/apache/infrastructure-actions/tree/main/stash#stash-github-action). I think it would help reduce API calls like comments listing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
