adoroszlai commented on code in PR #11830:
URL: https://github.com/apache/ozone/pull/11830#discussion_r4411387839
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/HddsVersionInfo.java:
##########
@@ -45,8 +45,6 @@ public static void main(String[] args) {
HDDS_VERSION_INFO.getRevision());
System.out.println(
"Compiled with protoc " + HDDS_VERSION_INFO.getProtoVersions());
- System.out.println(
- "From source with checksum " + HDDS_VERSION_INFO.getSrcChecksum());
Review Comment:
Thanks @sadanand48 for taking a look.
Yes, MD5 checksum has been present since the start, it was copied from
Hadoop.
- For builds from Git repository, commit SHA is known and more useful.
- Builds from source tarball (no Git repo) will not have commit SHA. I
doubt the MD5 sum of _some but not all_ files (e.g. excludes
`ozone-default.xml` and other resources) is useful even in that case. What
would one do with that information? Build locally and check if the checksum is
the same? I think we can use [`diffoscope`](https://diffoscope.org/) for
individual pairs of jars and gain more insight, like the diff shown in PR
description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
