neils-dev commented on pull request #2485:
URL: https://github.com/apache/ozone/pull/2485#issuecomment-894586807
Thanks for reviewing this and the comments @adoroszlai. Following up on
what we discussed earlier offline, the feature is incrementally submitted as
PRs to merge into the feature branch. The initial PR contained modifications
to the build - pom files associated with gRPC and we would like to proceed the
incremental PR submission with a commit that selects the grpc om transport
(factory) for the s3g gRPC transport. In addition included in this PR are
changes to the system build that provides a 'green build' to build upon (seen
with the unit, integration and acceptance test environments). Initially we did
not include the implementation for the gRPC om transport factory as it is
directly coupled with the client (HDDS-5212). If we can proceed with this, we
can look to
1. Change the title of the PR and associated jira to "Create service
provider for GrpcOmTransport and supporting build" from "Create and a specific
OmTransportFactory for GrpcOmTransport"
2. Follow up with HDDS-5212 including the initial client side implementation.
> Thanks @neils-dev for working on this.
>
> > GrpcOmTransportFactory (not included in this PR).
>
> I might be missing something, but not including `GrpcOmTransportFactory`
in a PR with the title "Create and a specific OmTransportFactory for
GrpcOmTransport" sounds contradictory.
>
> I think it would be better to publish the `GrpcOmTransport` implemention
first ([HDDS-5212](https://issues.apache.org/jira/browse/HDDS-5212)), and only
afterwards add the service definition for the factory
([HDDS-5213](https://issues.apache.org/jira/browse/HDDS-5213)). That seems to
be the logical order for these subtasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
