neils-dev commented on pull request #2485: URL: https://github.com/apache/ozone/pull/2485#issuecomment-895719050
> The question is: why not follow the logical order of the initial four sub-tasks? Why create a META-INF service descriptor pointing to a non-existing class? Creating a PR for [HDDS-5212](https://issues.apache.org/jira/browse/HDDS-5212) first would save you from disabling lots of tests, then enabling them again in the next PR. Thanks @adoroszlai. Ha, not looking to complicate, we will be able to go through the subtasks - not to worry. It is simpler with the transport factory service provider and the build setup _following_ the gRPC client/server generation (HDDS-5210 submitted and reviewed - thanks!). On the disabling of tests, here we have setup the environment to decouple the s3g implementation from the integration tests and disabled acceptance tests that we won't be able to re-enable until at least the subtasks HDDS-5210 through HDDS-5213 are submitted. > The question is: why not follow the logical order of the initial four sub-tasks? It is simpler - proceed the pom changes (HDDS-5210) with setting up the build environ and the service provider. Will follow with the client (dependent on the factory), etc (btw we will be adding subtasks for the s3g ozoneclientproducer & cache, endpoint, cdi filter). As an side, as we discussed previously offline, I have a sketch of what we can look to do for the incremental PRs and merges to the feature branch for this feature. I'll share it with you and we can discuss. > That's fine. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
