yandrey321 commented on PR #11939:
URL: https://github.com/apache/ozone/pull/11939#issuecomment-6649321178
@jojochuang addressed review comments:
1. **Object Content-Type:** `s3kg` now sets `text/plain` on its PutObject,
as SDK v1 did for its `String` content.
The body stays `RequestBody.fromBytes`. `s3/freon.robot` now checks the
content type of an `s3kg` key with
`head-object`. Multipart uploads keep the SDK's default, as they did with
v1.
2. **Credential aliases:** freon now has its own
`FreonEnvironmentCredentialsProvider`, which reads the environment
exactly as v1's `EnvironmentVariableCredentialsProvider` did:
- the access key comes from `AWS_ACCESS_KEY_ID`, or else `AWS_ACCESS_KEY`;
- the secret key comes from `AWS_SECRET_KEY`, or else
`AWS_SECRET_ACCESS_KEY`.
- a variable falls back to its alternate only when it is unset, not when
it is empty;
- values are trimmed;
- `AWS_SESSION_TOKEN` gives session credentials.
`TestFreonEnvironmentCredentialsProvider` covers each of these, plus the
error when a key is missing.
3. **Presigned unsupported subresources:** ported as
`PresignedUrlTests#testPresignedUrlGetObjectSubresourceNotImplemented`
(`annotation`, `torrent`). It presigns
GetObject with `putRawQueryParameter(subresource, "")`, expects 501, and
checks the object is unchanged.
4. **Explicit part zero:** `testGetParticularPart` now also GETs with
`partNumber(0)` and asserts the whole object
is returned.
Added compatibility notes in JIRA's release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
