yandrey321 commented on PR #11939:
URL: https://github.com/apache/ozone/pull/11939#issuecomment-6652418302
@adoroszlai I think it would be safer and cleaner to remove aws sdk v1 from
the code base.
**A complete ban is simpler and harder to get wrong.** With v1 gone, the
enforcer can ban `com.amazonaws` outright:
imports in main and test code, and any dependency, transitive included. A
test-only exception needs scope-aware
rules, and a v1 artifact pulled in transitively at compile scope could
slip past them.
**v1 is end of life,** so it gets no more fixes. That includes fixes for its
transitive dependencies
(`jackson-dataformat-cbor`, `jmespath-java`), which we would keep pinning
and updating in the root pom. Even
test-only, v1 stays in our dependency management and in the scanner
reports we triage.
**Two copies of the same suite cost more to keep than they catch.**
- I mapped every v1 test to the v2 suite by what it asserts. 59 of the 86
were already covered by v2, often with
stronger assertions. For example, v2 asserts the 412 where v1 only gets
`null` back from a failed conditional copy.
- For the rest, I ported 23 tests to v2. Three were hidden behind v2
tests of the same name that only check the
bucket-owner header (`testDeleteBucket`, `testListMultipartUploads`,
`testListParts`). What wasn't ported only
tests the v1 client itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
