fmorg-git commented on code in PR #11910:
URL: https://github.com/apache/ozone/pull/11910#discussion_r4461247877


##########
hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-sts.robot:
##########
@@ -93,36 +93,47 @@ ${STS_LIFECYCLE_JSON}                   
{"Rules":[{"ID":"sts-lifecycle-rule","Pr
 
 *** Keywords ***
 Populate Iceberg Bucket
-    [Arguments]                   ${bucket}
-    FOR    ${key}    IN    @{ICEBERG_OBJECT_KEYS}
-        ${parent} =               Evaluate                      
__import__('os').path.dirname($key)
-        Run Keyword If            '${parent}' != ''             Execute    
mkdir -p ${TEMP_DIR}/${parent}
-        ${local_path} =           Set Variable                  
${TEMP_DIR}/${key}
-        Create File               ${local_path}                 iceberg test 
content
-        Execute                   ozone sh key put /s3v/${bucket}/${key} 
${local_path}
-    END
-    Create File                   ${TEMP_DIR}/zeroByteFile
-    Execute                       ozone sh key put /s3v/${bucket}/zeroByteFile 
${TEMP_DIR}/zeroByteFile
+    [Arguments]    ${bucket}    ${layout}
+
+    ${local_path} =    Set Variable    ${TEMP_DIR}/iceberg-test-content
+
+    Create File    ${local_path}    iceberg test content
+    Create File    ${TEMP_DIR}/zeroByteFile
+
+    Ozone Shell Batch
+    ...    bucket create --layout ${layout} /s3v/${bucket}
+    ...    key put /s3v/${bucket}/file1.txt ${local_path}
+    ...    key put /s3v/${bucket}/file1.txt ${local_path}

Review Comment:
   it looks like `file1.txt` is added twice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to