chihsuan commented on code in PR #11977:
URL: https://github.com/apache/ozone/pull/11977#discussion_r4506422396


##########
.github/workflows/ci.yml:
##########
@@ -220,7 +216,7 @@ jobs:
         check: ${{ fromJson(needs.build-info.outputs.basic-checks) }}
         exclude:
           - check: errorprone
-      fail-fast: false
+      fail-fast: true

Review Comment:
   > 4. Enable `fail-fast` for `basic` checks matrix.
   
   Just curious, what's the reason for enabling `fail-fast`?  I don't feel 
strongly either way, just want to understand the trade-off. 🙂



##########
.github/workflows/ci.yml:
##########
@@ -179,18 +179,13 @@ jobs:
     if: needs.build-info.outputs.needs-compile == 'true'
     strategy:
       matrix:
-        java: [ 25 ]
-        include:
-          - os: ubuntu-24.04
-          - java: 21
-            os: macos-15

Review Comment:
   Dropping this for forks makes sense given GitHub runner capacity. Just a 
thought, if we still want this coverage, maybe we could keep it for scheduled 
builds in master? Totally fine to drop it if it's no longer needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to