smengcl commented on code in PR #11977:
URL: https://github.com/apache/ozone/pull/11977#discussion_r4518442733


##########
.github/workflows/ci.yml:
##########
@@ -179,11 +179,10 @@ jobs:
     if: needs.build-info.outputs.needs-compile == 'true'
     strategy:
       matrix:
-        java: [ 25 ]
-        include:
-          - os: ubuntu-24.04
-          - java: 21
-            os: macos-15
+        java:
+          - 25

Review Comment:
   With the Java 21 entry gone, I think nothing in CI builds with JDK 21 
anymore (the other jobs in `ci.yml` use `TEST_JAVA_VERSION` 25. acceptance uses 
11). So the `aspectj-java21-24` profile and `-Dozone.java.version.server=21` 
would no longer be exercised.
   
   Since the macOS entry now only runs on non-push events, could it keep using 
Java 21 as before? Something like:
   
   ```yaml
           java:
             - ${{ github.event_name == 'push' && 25 || 21 }}
   ```
   
   That would keep both the macOS and the Java 21 coverage in the scheduled 
build at no extra cost. I'm fine to leave it as is if Java 21 compile is no 
longer needed.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to