sumitagrawl commented on code in PR #11962:
URL: https://github.com/apache/ozone/pull/11962#discussion_r4533749386


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java:
##########
@@ -233,6 +262,41 @@ private void addReports(SCMHeartbeatRequestProto.Builder 
requestBuilder) {
         }
       }
     }
+    return reportCount;
+  }
+
+  private CommandStatusReportSelection addCommandStatusReports(
+      SCMHeartbeatRequestProto.Builder requestBuilder,
+      int remainingReportCount) {
+    long currentHeartbeatSize = requestBuilder.build().getSerializedSize();

Review Comment:
   10% is huge size, approx 12MB, so its expected to capture tag and other 
metadata in it.
   
   protobuf message is serialized data in byte array as experimented earlier 
and faced performance issue, so this is removed in places earlier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to