sumitagrawl commented on code in PR #11962:
URL: https://github.com/apache/ozone/pull/11962#discussion_r4549659957
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java:
##########
@@ -148,25 +170,34 @@ public EndpointStateMachine.EndPointStates call() throws
Exception {
requestBuilder = SCMHeartbeatRequestProto.newBuilder()
.setDatanodeDetails(datanodeDetailsProto)
.setDatanodeVersion(versionInfo);
- addReports(requestBuilder);
+ int reportCount = addNonCommandStatusReports(requestBuilder);
addContainerActions(requestBuilder);
addPipelineActions(requestBuilder);
addQueuedCommandCounts(requestBuilder);
+ commandStatusSelection = addCommandStatusReports(
+ requestBuilder, maxReportsPerHB - reportCount);
SCMHeartbeatRequestProto request = requestBuilder.build();
LOG.debug("Sending heartbeat message : {}", request);
SCMHeartbeatResponseProto response = rpcEndpoint.getEndPoint()
.sendHeartbeat(request);
processResponse(response, datanodeDetailsProto);
rpcEndpoint.setLastSuccessfulHeartbeat(ZonedDateTime.now());
rpcEndpoint.zeroMissedCount();
- if (context.hasPendingReports(rpcEndpoint.getAddress())) {
- // addReports was capped at maxReportsPerHB and left reports queued.
Trigger immediately.
- context.getParent().setNextHB(Time.monotonicNow());
+ if (context.getQueueMetrics() != null) {
Review Comment:
As per default configuration for max number of transactions from SCM, 500k *
60Bytes approx = 3-4MB max.
So each transaction will not go to huge number and keeping each response
one-by-one will be helpful and split is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]